Changeset 4305 for pjproject/trunk

Timestamp:

Dec 5, 2012 10:40:56 AM (12 years ago)

Author:

bennylp

Message:

Misc (re #1562): Add a protection in med_tp_timer_cb() against call that may have been terminated before ICE callback is called. It has been reported that this has caused a crash, but we cannot reproduce it. Thanks Karina for the report.

File:

• pjproject/trunk/pjsip/src/pjsua-lib/pjsua_media.c (modified) (1 diff)

pjproject/trunk/pjsip/src/pjsua-lib/pjsua_media.c

@@ -571 +571 @@
         pjsip_dialog *dlg = NULL;
 
-        acquire_call("med_tp_timer_cb", call_med->call->index, &call, &dlg);
+        if (acquire_call("med_tp_timer_cb", call_med->call->index,
+                         &call, &dlg) != PJ_SUCCESS)
+        {
+            /* Call have been terminated */
+            return;
+        }
 
         (*call_med->med_create_cb)(call_med, call_med->tp_ready,