Changeset 426 for pjproject/trunk

Timestamp:

May 2, 2006 5:44:28 PM (19 years ago)

Author:

bennylp

Message:

Do not disable port if put_frame()/get_frame() returns error

File:

• pjproject/trunk/pjmedia/src/pjmedia/conference.c (modified) (4 diffs)

pjproject/trunk/pjmedia/src/pjmedia/conference.c

@@ -1363 +1363 @@
             
             if (status != PJ_SUCCESS) {
+                /* bennylp: why do we need this????
+                 * Also see comments on similar issue with write_port().
                 PJ_LOG(4,(THIS_FILE, "Port %.*s get_frame() returned %d. "
                                      "Port is now disabled",
@@ -1369 +1371 @@
                                      status));
                 conf_port->rx_setting = PJMEDIA_PORT_DISABLE;
+                 */
                 continue;
             }
@@ -1464 +1467 @@
         status = write_port( conf, conf_port, frame->timestamp.u32.lo);
         if (status != PJ_SUCCESS) {
+            /* bennylp: why do we need this????
+               One thing for sure, put_frame()/write_port() may return
+               non-successfull status on Win32 if there's temporary glitch
+               on network interface, so disabling the port here does not
+               sound like a good idea.
+
             PJ_LOG(4,(THIS_FILE, "Port %.*s put_frame() returned %d. "
                                  "Port is now disabled",
@@ -1470 +1479 @@
                                  status));
             conf_port->tx_setting = PJMEDIA_PORT_DISABLE;
+            */
             continue;
         }