Changeset 426


Ignore:
Timestamp:
May 2, 2006 5:44:28 PM (18 years ago)
Author:
bennylp
Message:

Do not disable port if put_frame()/get_frame() returns error

File:
1 edited

Legend:

Unmodified
Added
Removed
  • pjproject/trunk/pjmedia/src/pjmedia/conference.c

    r411 r426  
    13631363             
    13641364            if (status != PJ_SUCCESS) { 
     1365                /* bennylp: why do we need this???? 
     1366                 * Also see comments on similar issue with write_port(). 
    13651367                PJ_LOG(4,(THIS_FILE, "Port %.*s get_frame() returned %d. " 
    13661368                                     "Port is now disabled", 
     
    13691371                                     status)); 
    13701372                conf_port->rx_setting = PJMEDIA_PORT_DISABLE; 
     1373                 */ 
    13711374                continue; 
    13721375            } 
     
    14641467        status = write_port( conf, conf_port, frame->timestamp.u32.lo); 
    14651468        if (status != PJ_SUCCESS) { 
     1469            /* bennylp: why do we need this???? 
     1470               One thing for sure, put_frame()/write_port() may return 
     1471               non-successfull status on Win32 if there's temporary glitch 
     1472               on network interface, so disabling the port here does not 
     1473               sound like a good idea. 
     1474 
    14661475            PJ_LOG(4,(THIS_FILE, "Port %.*s put_frame() returned %d. " 
    14671476                                 "Port is now disabled", 
     
    14701479                                 status)); 
    14711480            conf_port->tx_setting = PJMEDIA_PORT_DISABLE; 
     1481            */ 
    14721482            continue; 
    14731483        } 
Note: See TracChangeset for help on using the changeset viewer.