Changeset 3969 for pjproject/branches/1.x/pjmedia/include/pjmedia/rtcp_xr.h

Timestamp:

Mar 8, 2012 8:34:30 AM (12 years ago)

Author:

nanang

Message:

Fix #1440:

• Use separate buffer for outgoing RTCP. Previously, RTCP generation might override outgoing RTP payload (because of shared buffer).
• Use exact size for RTCP-XR content buffer. Previously RTCP-XR content buffer size was set to PJMEDIA_MAX_MTU, quite huge wasted space.

File:

• pjproject/branches/1.x/pjmedia/include/pjmedia/rtcp_xr.h (modified) (2 diffs)

pjproject/branches/1.x/pjmedia/include/pjmedia/rtcp_xr.h

@@ -201 +201 @@
 } pjmedia_rtcp_xr_rb_voip_mtc;
 
+
+/**
+ * Constant of RTCP-XR content size.
+ */
+#define PJMEDIA_RTCP_XR_BUF_SIZE \
+    sizeof(pjmedia_rtcp_xr_rb_rr_time) + \
+    sizeof(pjmedia_rtcp_xr_rb_dlrr) + \
+    sizeof(pjmedia_rtcp_xr_rb_stats) + \
+    sizeof(pjmedia_rtcp_xr_rb_voip_mtc)
+
+
 /**
  * This structure declares RTCP XR (Extended Report) packet.
@@ -222 +233 @@
     } common;
 
-    pj_int8_t            buf[PJMEDIA_MAX_MTU];/**< Content buffer   */
+    pj_int8_t            buf[PJMEDIA_RTCP_XR_BUF_SIZE];
+                                        /**< Content buffer   */
 } pjmedia_rtcp_xr_pkt;