Changeset 3959 for pjproject/branches/1.x/pjsip/src/pjsip-ua/sip_inv.c

Timestamp:

Feb 27, 2012 9:12:13 AM (13 years ago)

Author:

bennylp

Message:

Fixed #1455: Incoming re-INVITE is unhandled if it comes in CONNECTING state (thanks Olle Frimanson for the report)

File:

• pjproject/branches/1.x/pjsip/src/pjsip-ua/sip_inv.c (modified) (2 diffs)

pjproject/branches/1.x/pjsip/src/pjsip-ua/sip_inv.c

@@ -3852 +3852 @@
     } else if (tsx->role == PJSIP_ROLE_UAS &&
                tsx->state == PJSIP_TSX_STATE_TRYING &&
+               pjsip_method_cmp(&tsx->method, &pjsip_invite_method)==0)
+    {
+        pjsip_rx_data *rdata = e->body.tsx_state.src.rdata;
+        pjsip_tx_data *tdata;
+        pj_status_t status;
+
+        /* See https://trac.pjsip.org/repos/ticket/1455
+         * Handle incoming re-INVITE before current INVITE is confirmed.
+         * According to RFC 5407:
+         *  - answer with 200 if we don't have pending offer-answer
+         *  - answer with 491 if we *have* pending offer-answer
+         *
+         *  But unfortunately accepting the re-INVITE would mean we have
+         *  two outstanding INVITEs, and we don't support that because
+         *  we will get confused when we handle the ACK.
+         */
+        status = pjsip_dlg_create_response(inv->dlg, rdata,
+                                           PJSIP_SC_REQUEST_PENDING,
+                                           NULL, &tdata);
+        if (status != PJ_SUCCESS)
+            return;
+        pjsip_timer_update_resp(inv, tdata);
+        status = pjsip_dlg_send_response(dlg, tsx, tdata);
+
+    } else if (tsx->role == PJSIP_ROLE_UAS &&
+               tsx->state == PJSIP_TSX_STATE_TRYING &&
                pjsip_method_cmp(&tsx->method, &pjsip_update_method)==0)
     {
@@ -3884 +3910 @@
         /* Generic handling for UAC tsx completion */
         handle_uac_tsx_response(inv, e);
+
     }