Changeset 3383 for pjproject/trunk/pjsip/src/pjsua-lib/pjsua_media.c

Timestamp:

Dec 2, 2010 10:41:46 AM (13 years ago)

Author:

bennylp

Message:

Fixed #1170 (Assertion when receiving updated SDP offer with all media lines removed):

• pjsua_media.c checks if audio media is present in the offer; if not, do not set any answer
• sip_inv.c checks if app has supplied an answer after on_rx_offer() callback is called, and returnd 488 (Not Acceptable) if not (previously, it will return 200/OK without SDP!)
• added a SIPp scenario file to reproduce this

File:

• pjproject/trunk/pjsip/src/pjsua-lib/pjsua_media.c (modified) (1 diff)

pjproject/trunk/pjsip/src/pjsua-lib/pjsua_media.c

@@ -1312 +1312 @@
 
         call->audio_idx = find_audio_index(rem_sdp, srtp_active);
+        if (call->audio_idx == -1) {
+            /* No audio in the offer. We can't accept this */
+            PJ_LOG(4,(THIS_FILE,
+                      "Unable to accept SDP offer without audio for call %d",
+                      call_id));
+            return PJMEDIA_SDP_EINMEDIA;
+        }
     }