Ignore:
Timestamp:
Jun 23, 2010 12:38:28 PM (12 years ago)
Author:
bennylp
Message:

Fixed #1079 (Media transport should be kept alive during double-hold scenario). Details:

  • now the stream will be destroyed but the media transport will be kept alive during doublehold scenario
  • small fix in SRTP to also negotiate crypto even when the media is marked as inactive, otherwise it's possible that an "optional" endpoint would create RTP/AVP offer and send it to "mandatory" endpoint, which would be rejected and cause the media port to be set to zero
File:
1 edited

Legend:

Unmodified
Added
Removed
  • pjproject/trunk/pjmedia/src/pjmedia/transport_srtp.c

    r3191 r3219  
    11661166 
    11671167    /* If the media is inactive, do nothing. */ 
     1168    /* No, we still need to process SRTP offer/answer even if the media is 
     1169     * marked as inactive, because the transport is still alive in this 
     1170     * case (e.g. for keep-alive). See: 
     1171     *   http://trac.pjsip.org/repos/ticket/1079 
     1172     */ 
     1173    /* 
    11681174    if (pjmedia_sdp_media_find_attr(m_loc, &ID_INACTIVE, NULL) ||  
    11691175        (m_rem && pjmedia_sdp_media_find_attr(m_rem, &ID_INACTIVE, NULL))) 
    11701176        goto BYPASS_SRTP; 
     1177    */ 
    11711178 
    11721179    /* Check remote media transport & set local media transport  
Note: See TracChangeset for help on using the changeset viewer.