Changeset 2643 for pjproject

Timestamp:

Apr 23, 2009 11:50:25 AM (16 years ago)

Author:

bennylp

Message:

Fixed ticket #794: Bug with generating SDP version in origin line (thanks Joel Dodson for the report)

• the INVITE session now correctly uses the SDP offer "fixed" by the negotiator, hence it will have the correct origin fields.
• removed update_sdp_version() from PJSUA-LIB
• the negotiator now also fixes the session ID of subsequent answer so that it's identical to the previous SDP

Location:

pjproject/trunk

Files:

• pjmedia/src/pjmedia/sdp_neg.c (modified) (1 diff)
• pjsip/src/pjsip-ua/sip_inv.c (modified) (3 diffs)
• pjsip/src/pjsua-lib/pjsua_call.c (modified) (5 diffs)

pjproject/trunk/pjmedia/src/pjmedia/sdp_neg.c

@@ -423 +423 @@
     neg->state = PJMEDIA_SDP_NEG_STATE_WAIT_NEGO;
     if (local) {
-        if (!neg->initial_sdp) {
+        neg->neg_local_sdp = pjmedia_sdp_session_clone(pool, local);
+        if (neg->initial_sdp) {
+            /* I don't think there is anything in RFC 3264 that mandates
+             * answerer to place the same origin (and increment version)
+             * in the answer, but probably it won't hurt either.
+             * Note that the version will be incremented in 
+             * pjmedia_sdp_neg_negotiate()
+             */
+            neg->neg_local_sdp->origin.id = neg->initial_sdp->origin.id;
+        } else {
             neg->initial_sdp = pjmedia_sdp_session_clone(pool, local);
         }
-        neg->neg_local_sdp = pjmedia_sdp_session_clone(pool, local);
     } else {
         PJ_ASSERT_RETURN(neg->initial_sdp, PJMEDIA_SDPNEG_ENOINITIAL);

pjproject/trunk/pjsip/src/pjsip-ua/sip_inv.c

@@ -2249 +2249 @@
     }
 
+    /* Notify negotiator about the new offer. This will fix the offer
+     * with correct SDP origin.
+     */
     status = pjmedia_sdp_neg_modify_local_offer(inv->pool,inv->neg,
                                                 offer);
@@ -2254 +2257 @@
         goto on_error;
 
+    /* Retrieve the "fixed" offer from negotiator */
+    pjmedia_sdp_neg_get_neg_local(inv->neg, &offer);
 
     /* Update Contact if required */
@@ -3620 +3625 @@
                     (*mod_inv.cb.on_create_offer)(inv, &sdp);
                     if (sdp) {
+                        /* Notify negotiator about the new offer. This will
+                         * fix the offer with correct SDP origin.
+                         */
                         status = pjmedia_sdp_neg_modify_local_offer(dlg->pool,
                                                                     inv->neg,
                                                                     sdp);
+
+                        /* Retrieve the "fixed" offer from negotiator */
+                        if (status==PJ_SUCCESS)
+                            pjmedia_sdp_neg_get_neg_local(inv->neg, &sdp);
                     }
                 } 

pjproject/trunk/pjsip/src/pjsua-lib/pjsua_call.c

@@ -78 +78 @@
 static pj_status_t create_sdp_of_call_hold(pjsua_call *call,
                                            pjmedia_sdp_session **p_answer);
-
-/* Update SDP version in the offer */
-static void update_sdp_version(pjsua_call *call,
-                               pjmedia_sdp_session *sdp)
-{
-    const pjmedia_sdp_session *old_sdp = NULL;
-    pj_status_t status;
-
-    status = pjmedia_sdp_neg_get_active_local(call->inv->neg, &old_sdp);
-    if (status != PJ_SUCCESS || old_sdp == NULL)
-        return;
-
-    sdp->origin.version = old_sdp->origin.version + 1;
-}
-
 
 /*
@@ -1520 +1505 @@
     }
 
-    update_sdp_version(call, sdp);
-
     /* Create re-INVITE with new offer */
     status = pjsip_inv_reinvite( call->inv, NULL, sdp, &tdata);
@@ -1592 +1575 @@
     }
 
-    update_sdp_version(call, sdp);
-
     /* Create re-INVITE with new offer */
     status = pjsip_inv_reinvite( call->inv, NULL, sdp, &tdata);
@@ -1650 +1631 @@
         return status;
     }
-
-    update_sdp_version(call, sdp);
 
     /* Create UPDATE with new offer */
@@ -3322 +3301 @@
     }
 
-    update_sdp_version(call, *offer);
-
     PJSUA_UNLOCK();
 }