Changeset 196 for pjproject/trunk/pjsip/include/pjsip/sip_dialog.h

Timestamp:

Feb 19, 2006 1:37:35 AM (18 years ago)

Author:

bennylp

Message:

Fixed premature dialog deletion, causing crash

File:

• pjproject/trunk/pjsip/include/pjsip/sip_dialog.h (modified) (2 diffs)

pjproject/trunk/pjsip/include/pjsip/sip_dialog.h

@@ -208 +208 @@
  * the value directly by accessing dlg->mod_data[module_id].
  */
-PJ_INLINE(pj_status_t) pjsip_dlg_set_mod_data( pjsip_dialog *dlg,
-                                               int mod_id,
-                                               void *data )
-{
-    PJ_ASSERT_RETURN(dlg, PJ_EINVAL);
-    PJ_ASSERT_RETURN(mod_id >= 0 && mod_id < PJSIP_MAX_MODULE,
-                     PJ_EINVAL);
-    dlg->mod_data[mod_id] = data;
-    return PJ_SUCCESS;
-}
+PJ_DECL(pj_status_t) pjsip_dlg_set_mod_data( pjsip_dialog *dlg,
+                                             int mod_id,
+                                             void *data );
 
 /**
@@ -223 +216 @@
  * can also get value directly by accessing dlg->mod_data[module_id].
  */
-PJ_INLINE(void*) pjsip_dlg_get_mod_data(pjsip_dialog *dlg,
-                                        int mod_id)
-{
-    PJ_ASSERT_RETURN(dlg, NULL);
-    PJ_ASSERT_RETURN(mod_id >= 0 && mod_id < PJSIP_MAX_MODULE,
-                     NULL);
-    return dlg->mod_data[mod_id];
-}
-
+PJ_DECL(void*) pjsip_dlg_get_mod_data( pjsip_dialog *dlg,
+                                       int mod_id);
+
+
+/**
+ * Lock dialog and increment session counter termporarily, to prevent it 
+ * from being destroyed.
+ */
+PJ_DECL(void) pjsip_dlg_inc_lock( pjsip_dialog *dlg );
+
+/**
+ * Unlock dialog and decrement temporary session counter. After this function
+ * is called, dialog may be destroyed.
+ */
+PJ_DECL(void) pjsip_dlg_dec_lock( pjsip_dialog *dlg );