Changeset 1905 for pjproject/trunk/pjlib/src/pj/ioqueue_select.c

Timestamp:

Apr 2, 2008 6:36:35 PM (16 years ago)

Author:

bennylp

Message:

Ticket #520: Race condition may cause ioqueue corruption (thanks Philippe Leuba)

File:

• pjproject/trunk/pjlib/src/pj/ioqueue_select.c (modified) (1 diff)

pjproject/trunk/pjlib/src/pj/ioqueue_select.c

@@ -446 +446 @@
     pj_assert(ioqueue->count > 0);
     --ioqueue->count;
+#if !PJ_IOQUEUE_HAS_SAFE_UNREG
+    /* Ticket #520, key will be erased more than once */
     pj_list_erase(key);
+#endif
     PJ_FD_CLR(key->fd, &ioqueue->rfdset);
     PJ_FD_CLR(key->fd, &ioqueue->wfdset);