Changeset 1888 for pjproject/trunk/pjnath/include/pjnath/stun_msg.h

Timestamp:

Mar 22, 2008 9:33:26 AM (16 years ago)

Author:

bennylp

Message:

Added comment about byte ordering in TURN CHANNEL-NUMBER attribute and modified select() parameter in TURN client

File:

• pjproject/trunk/pjnath/include/pjnath/stun_msg.h (modified) (2 diffs)

pjproject/trunk/pjnath/include/pjnath/stun_msg.h

@@ -873 +873 @@
 /**
  * Get 16bit channel number from 32bit integral value.
+ * Note that uint32 attributes are always stored in host byte order
+ * after they have been parsed from the PDU, so no need to do ntohs()
+ * here.
  */
 #define PJ_STUN_GET_CH_NB(u32)      ((pj_uint16_t)(u32>>16))
@@ -878 +881 @@
 /**
  * Convert 16bit channel number into 32bit integral value.
+ * Note that uint32 attributes will be converted to network byte order
+ * when the attribute is written to packet, so no need to do htons()
+ * here.
  */
 #define PJ_STUN_SET_CH_NB(chnum)    (((pj_uint32_t)chnum) << 16)