Changeset 3547 for pjproject/trunk/pjmedia/src/pjmedia/transport_ice.c

Timestamp:

Apr 28, 2011 4:01:40 AM (13 years ago)

Author:

ming

Message:

Fixed #1243: ICE bug: If RTCP is not in use, the agent MUST signal that using b=RS:0 and b=RR:0

File:

• pjproject/trunk/pjmedia/src/pjmedia/transport_ice.c (modified) (2 diffs)

pjproject/trunk/pjmedia/src/pjmedia/transport_ice.c

@@ -175 +175 @@
 static const pj_str_t STR_IP6           = { "IP6", 3 };
 static const pj_str_t STR_RTCP          = { "rtcp", 4 };
+static const pj_str_t STR_BANDW_RR      = { "RR", 2 };
+static const pj_str_t STR_BANDW_RS      = { "RS", 2 };
 
 enum {
@@ -602 +604 @@
         if (attr)
             pjmedia_sdp_attr_remove(&m->attr_count, m->attr, attr);
+        /* If RTCP is not in use, we MUST send b=RS:0 and b=RR:0. */
+        pj_assert(m->bandw_count + 2 <= PJ_ARRAY_SIZE(m->bandw));
+        if (m->bandw_count + 2 <= PJ_ARRAY_SIZE(m->bandw)) {
+            m->bandw[m->bandw_count] = PJ_POOL_ZALLOC_T(sdp_pool,
+                                                        pjmedia_sdp_bandw);
+            pj_memcpy(&m->bandw[m->bandw_count]->modifier, &STR_BANDW_RS,
+                      sizeof(pj_str_t));
+            m->bandw_count++;
+            m->bandw[m->bandw_count] = PJ_POOL_ZALLOC_T(sdp_pool,
+                                                        pjmedia_sdp_bandw);
+            pj_memcpy(&m->bandw[m->bandw_count]->modifier, &STR_BANDW_RR,
+                      sizeof(pj_str_t));
+            m->bandw_count++;
+        }
     }