Changeset 3219 for pjproject/trunk/pjsip/src/pjsua-lib/pjsua_media.c

Timestamp:

Jun 23, 2010 12:38:28 PM (14 years ago)

Author:

bennylp

Message:

Fixed #1079 (Media transport should be kept alive during double-hold scenario). Details:

• now the stream will be destroyed but the media transport will be kept alive during doublehold scenario
• small fix in SRTP to also negotiate crypto even when the media is marked as inactive, otherwise it's possible that an "optional" endpoint would create RTP/AVP offer and send it to "mandatory" endpoint, which would be rejected and cause the media port to be set to zero

File:

• pjproject/trunk/pjsip/src/pjsua-lib/pjsua_media.c (modified) (2 diffs)

pjproject/trunk/pjsip/src/pjsua-lib/pjsua_media.c

@@ -1558 +1558 @@
         call->media_dir = PJMEDIA_DIR_NONE;
 
+        /* Don't stop transport because we need to transmit keep-alives, and
+         * also to prevent restarting ICE negotiation. See
+         *  http://trac.pjsip.org/repos/ticket/1094
+         */
+#if 0
         /* Shutdown transport's session */
         pjmedia_transport_media_stop(call->med_tp);
@@ -1569 +1574 @@
             call->med_tp = call->med_orig;
         }
+#endif
 
     } else {