Changes between Initial Version and Version 1 of PJSUA_Locks


Ignore:
Timestamp:
Feb 12, 2008 12:23:59 PM (14 years ago)
Author:
bennylp
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • PJSUA_Locks

    v1 v1  
     1= Mutex Locks Order in PJSUA-LIB = 
     2 
     3There are many types of mutexes used in PJSIP, and both the library and application MUST obey a uniform lock order to avoid deadlocks. 
     4 
     5To lock a particular call in PJSUA-LIB, this mutex lock ordering MUST be used: 
     6 1. lock the dialog 
     7 1. lock the user agent mutex 
     8 1. lock PJSUA-LIB 
     9 1. lock application's mutex 
     10 
     11== Acquiring Locks in the Callbacks == 
     12 
     13The lock ordering above mimics the lock ordering of an incoming SIP message. The first two locks (dialog and user agent mutexes) happens automatically in PJSIP's user agent layer, and PJSIP will guarantee that the locking sequence for these two mutexes is obeyed all the time. If application wants  to acquire dialog's mutex, it just needs to call [http://www.pjsip.org/pjsip/docs/html/group__PJSIP__DIALOG.htm#g5d87304615303ffbe20a09e0a3ff59df pjsip_dlg_inc_lock()] or [http://www.pjsip.org/pjsip/docs/html/group__PJSIP__DIALOG.htm#gc50e4f3f62ee648b1c818e4450977f32 pjsip_dlg_try_inc_lock()] and PJSIP will take care of getting the mutexes locked in the correct sequence (application shall release the dialog lock with [http://www.pjsip.org/pjsip/docs/html/group__PJSIP__DIALOG.htm#g3283f8502b1df5d37914668338351a4f pjsip_dlg_dec_lock()]). Note that the user agent mutex will not be held unless dialog is being created or destroyed. 
     14 
     15The callback then reaches PJSUA-LIB, and PJSUA-LIB will acquire its mutex with {{{PJSUA_LOCK()}}} or {{{PJSUA_TRY_LOCK()}}} (and later it will release the mutex with {{{PJSUA_UNLOCK()}}} once it has finished with processing the event). These locking macros are currently not part of [http://www.pjsip.org/pjsip/docs/html/group__PJSUA__LIB.htm PJSUA public API], so if application ever wants to use these macros directly, it must include {{{<pjsua-lib/pjsua_internal.h>}}} header file. 
     16 
     17Finally the callback reaches application. At this stage, all locks (dialog and PJSUA-LIB) are held, and application can safely work with the call. If application employs its own (application) mutex, then this mutex may be acquired now. 
     18 
     19Once the callback returns, the locks will be released in the reverse order. 
     20 
     21== Acquiring Locks from the Application == 
     22 
     23When application initiates the API call (for example from a user interface event), application MUST ensure that the lock ordering above is obeyed at all times, otherwise deadlock will occur. 
     24 
     25If application doesn't use any mutexes in the application code, then nothing needs to be done. PJSUA-LIB will guarantee that the locks are always acquired in the standard order. If application does use application mutex, then the steps below must be taken to ensure that locks are acquired in standard order. 
     26 
     27Below are the steps required to acquire mutexes in the standard order: 
     28 1. Call {{{acquire_call()}}} function (declared in {{{<pjsua-lib/pjsua_internal.h>}}}. This function will acquire all the locks in the standard ordering above. Note that this function may return non-PJ_SUCCESS if locks cannot be acquired. The common reason of the failure is because other threads are currently acquiring the mutex and the function has detected that acquiring the mutex will result in deadlock condition. 
     29 1. Once {{{acquire_call()}}} returns successfully, application may then acquire the application mutex. 
     30 
     31Once application is done with the processing, it must release the locks in the reverse order: 
     32 1. Release application's mutex. 
     33 1. Release call's mutex by calling {{{pjsip_dlg_dec_lock()}}} (the dialog handle was returned by {{{acquire_call()}}} function). 
     34 
     35 
     36