1 | | Soundport's samples_per_frame is total samples number per frame of ALL channels. |
2 | | While PA's frameCount refers to number of samples for EACH channel. |
3 | | The PA callbacks implementations contains wrong assertion, since it is inconsistent with definitions above. |
| 1 | Identified issues: |
| 2 | - The PA callbacks implementations contains wrong assertion, because of samples_per_frame misinterpretation (thanks Rodrigo Vega, http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/2008-March/001974.html): |
| 3 | - Soundport's samples_per_frame is total samples number per frame of ALL channels. |
| 4 | - While PA's frameCount refers to number of samples for EACH channel. |
| 5 | - Lack of channel_count multiplication in samples_per_frame calculation in some parts of stream causing silence in stereo audio call. |
| 6 | - STEREO_DEMO in pjsua causing crash in PortAudio without call (perhaps because of some pointer to PA buffer get overwritten) |