Changes between Initial Version and Version 2 of Ticket #2173


Ignore:
Timestamp:
Jan 9, 2019 4:52:34 AM (5 months ago)
Author:
nanang
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2173

    • Property Status changed from new to closed
    • Property Component changed from pjsip to pjsua2
    • Property Resolution changed from to fixed
  • Ticket #2173 – Description

    initial v2  
    1 Ticket #1916 will enable ```on_incoming_call()``` called from ```on_create_media_transport()``` for PJSUA2. 
     1Ticket #1916 enables ```on_incoming_call()``` called from ```on_create_media_transport()``` for PJSUA2. 
    22 
    3 However, application isn't notified when SDP nego fails due to unsupported codec. 
    4 Hence application will unable to clear the call. 
     3However, after the ```on_incoming_call()``` invocation, there is a chance that the call is disconnected by the library (e.g: due to unsupported codec or unsupported SIP capability requirement). Unfortunately, there is a bug in the library that application will not be informed about the call disconnection in such scenario. 
    54 
    65The patch will add check for codec and capability support from the SDP before  
    76calling ```on_incoming_call()```. In this case, when the check fails then ```on_incoming_call()``` will not be called. 
    87 
     8However, actually there is still a chance of failure in further step of call verification, so the call may get rejected by the library after incoming call callback is invoked. In this case, call state callback ```on_call_state()``` will be invoked to notify application about call disconnection. 
     9 
    910Thanks to Ryan Wallach for the report.