Changes between Initial Version and Version 2 of Ticket #2173
- Timestamp:
- Jan 9, 2019 4:52:34 AM (6 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #2173
- Property Status changed from new to closed
- Property Component changed from pjsip to pjsua2
- Property Resolution changed from to fixed
-
Ticket #2173 – Description
initial v2 1 Ticket #1916 will enable```on_incoming_call()``` called from ```on_create_media_transport()``` for PJSUA2.1 Ticket #1916 enables ```on_incoming_call()``` called from ```on_create_media_transport()``` for PJSUA2. 2 2 3 However, application isn't notified when SDP nego fails due to unsupported codec. 4 Hence application will unable to clear the call. 3 However, after the ```on_incoming_call()``` invocation, there is a chance that the call is disconnected by the library (e.g: due to unsupported codec or unsupported SIP capability requirement). Unfortunately, there is a bug in the library that application will not be informed about the call disconnection in such scenario. 5 4 6 5 The patch will add check for codec and capability support from the SDP before 7 6 calling ```on_incoming_call()```. In this case, when the check fails then ```on_incoming_call()``` will not be called. 8 7 8 However, actually there is still a chance of failure in further step of call verification, so the call may get rejected by the library after incoming call callback is invoked. In this case, call state callback ```on_call_state()``` will be invoked to notify application about call disconnection. 9 9 10 Thanks to Ryan Wallach for the report.