Changes between Initial Version and Version 1 of Ticket #2063
- Timestamp:
- Nov 14, 2017 8:18:24 AM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #2063 – Description
initial v1 2 2 3 3 Also in the ticket: 4 - Modify the spec of pjlib-util's scanner. Originally, the spec said that the scanner will add the NULL terminator right AFTER the end of the buffer, however it turns out that the current implementation didn't do that, probably for a good reason, i.e. to avoid buffer overwrite. So, we change the spec instead, to require that the input buffer passed to the scanner needs to be NULL terminated by app. 4 5 - Add assertion in pjlib-util's scanner to ensure that the buffer is NULL terminated.[[br]] 5 6 If when using tools such as Valgrind or !AddressSanitizer, you get a buffer read overflow warning in this assertion line, it means that you incorrectly passed the buffer length (it should be buffer length - 1).