Custom Query (2195 matches)

The *current_file* variable is not always consistent and need to be updated specially when the last file in the list has been played otherwise there is a crash due to an access violation since it's used as an index for the playlist;

The statement

current_file = fport->current_file;

shall be the first statement in the *while (size_left > 0)* loop to fix that array index bug ;o)

Thanks Alain Totouom for the report/fix.

Currently the conference bridge will transmit PJMEDIA_FRAME_TYPE_NONE to a destination slot when the level is zero, regardless whether there is a source port transmitting to that particular destination slot:

  if (cport->tx_setting==PJMEDIA_PORT_MUTE || cport->srv_level==0) {
     frame.type = PJMEDIA_FRAME_TYPE_NONE;
     pjmedia_port_put_frame(cport->port, &frame);
  }

This will cause WAV writer to write nothing to the file, thus causing silence gap to not be written.

The solution, the bridge should distinguish between no listener situation and silence situation:

  if (cport->tx_setting == PJMEDIA_PORT_MUTE || cport->transmitter_cnt==0) {
       // Transmit TYPE_NONE frame
       ...
  } else if (cport->src_level==0) {
       // Transmit silence PCM frame
       ...
  }

Currently there is no timeout in SIP UAC transaction after provisional response is received. This will cause client to wait indefinetely if server crashes after it sends provisional response.

Note that this shouldn't be neccessary if the server is compliant with RFC 4420 and 4421 (re: not sending provisional response for non-INVITE transaction). But some popular open souce PBX out there does this anyway, so we'd better support this.