Changeset 945

Timestamp:

Feb 14, 2007 2:15:19 AM (18 years ago)

Author:

bennylp

Message:

Fixed ticket #93: Python readline() blocks/hang because C module running on different thread is calling a blocking OS call

File:

• pjproject/trunk/pjsip-apps/src/py_pjsua/py_pjsua.c (modified) (1 diff)

pjproject/trunk/pjsip-apps/src/py_pjsua/py_pjsua.c

@@ -2164 +2164 @@
         return NULL;
     }
+
+    /* Since handle_events() will block, we must wrap it with ALLOW_THREADS
+     * construct, or otherwise many Python blocking functions (such as
+     * time.sleep(), readline(), etc.) may hang/block indefinitely.
+     * See http://www.python.org/doc/current/api/threads.html for more info.
+     */
+    Py_BEGIN_ALLOW_THREADS
     ret = pjsua_handle_events(msec);
+    Py_END_ALLOW_THREADS
     
     return Py_BuildValue("i",ret);