Changeset 807

Timestamp:

Nov 19, 2006 8:28:34 PM (18 years ago)

Author:

bennylp

Message:

Fixed memory leaks bug in speex codec

Location:

pjproject/trunk/pjmedia/src/pjmedia-codec

Files:

• speex/sb_celp.c (modified) (2 diffs)
• speex_codec.c (modified) (2 diffs)

pjproject/trunk/pjmedia/src/pjmedia-codec/speex/sb_celp.c

@@ -362 +362 @@
    speex_free(st->interp_qlpc);
    speex_free(st->pi_gain);
+   speex_free(st->low_innov);
 
    speex_free(st->mem_sp);
@@ -925 +926 @@
    speex_free(st->pi_gain);
    speex_free(st->mem_sp);
+   speex_free(st->low_innov);
 
    speex_free(state);

pjproject/trunk/pjmedia/src/pjmedia-codec/speex_codec.c

@@ -311 +311 @@
     }
 
+    pj_mutex_lock(spx_factory.mutex);
+
     /* We don't want to deinit if there's outstanding codec. */
-    pj_mutex_lock(spx_factory.mutex);
+    /* This is silly, as we'll always have codec in the list if
+       we ever allocate a codec! A better behavior maybe is to 
+       deallocate all codecs in the list.
     if (!pj_list_empty(&spx_factory.codec_list)) {
         pj_mutex_unlock(spx_factory.mutex);
         return PJ_EBUSY;
     }
+    */
 
     /* Get the codec manager. */
@@ -743 +748 @@
     }
 
-    /* Initialization of the structure that holds the bits */
-    speex_bits_init(&spx->dec_bits);
-
     /* Copy the data into the bit-stream struct */
     speex_bits_read_from(&spx->dec_bits, input->buf, input->size);