Changeset 785 for pjproject/trunk/pjmedia/src/pjmedia/mp3_writer.c

Timestamp:

Oct 20, 2006 11:08:49 AM (18 years ago)

Author:

bennylp

Message:

Changed the processing of mp3 _options in mp3 writer with regard to bit_rate and quality to comply with LAME, also changed the pjsua_recorder_create() parameter to allow specifying mp3 options in one of the parameter

File:

• pjproject/trunk/pjmedia/src/pjmedia/mp3_writer.c (modified) (2 diffs)

pjproject/trunk/pjmedia/src/pjmedia/mp3_writer.c

@@ -200 +200 @@
         LConfig.format.LHV1.nVbrMethod = VBR_METHOD_DEFAULT;
         LConfig.format.LHV1.bWriteVBRHeader = 1;
-        //LConfig.format.LHV1.dwVbrAbr_bps = fport->mp3_option.bit_rate;
+        LConfig.format.LHV1.dwVbrAbr_bps = fport->mp3_option.bit_rate;
         LConfig.format.LHV1.bEnableVBR = 1;
     }
@@ -295 +295 @@
     }
 
-    /* Calculate bitrate if it's not specified */
-    if (fport->mp3_option.bit_rate == 0) 
+    /* Calculate bitrate if it's not specified, only if it's not VBR. */
+    if (fport->mp3_option.bit_rate == 0 && !fport->mp3_option.vbr) 
         fport->mp3_option.bit_rate = sampling_rate * channel_count;