Changeset 785 for pjproject/trunk/pjmedia/include/pjmedia/mp3_port.h

Timestamp:

Oct 20, 2006 11:08:49 AM (18 years ago)

Author:

bennylp

Message:

Changed the processing of mp3 _options in mp3 writer with regard to bit_rate and quality to comply with LAME, also changed the pjsua_recorder_create() parameter to allow specifying mp3 options in one of the parameter

File:

• pjproject/trunk/pjmedia/include/pjmedia/mp3_port.h (modified) (1 diff)

pjproject/trunk/pjmedia/include/pjmedia/mp3_port.h

@@ -60 +60 @@
 typedef struct pjmedia_mp3_encoder_option
 {
-    /** Specify whether variable bit rate should be used (say Yes!).        */
+    /** Specify whether variable bit rate should be used. Variable bitrate
+     *  would normally produce better quality at the expense of probably
+     *  larger file.
+     */
     pj_bool_t   vbr;
 
-    /** Target bitrate, in bps. If zero, bitrate will be  calculated.       */
+    /** Target bitrate, in bps. For VBR, if the bitrate is specified, then 
+     *  the encoder will ignore the quality settings and instead will try to 
+     *  limit the bitrate to the desired value in this setting.
+     */
     unsigned    bit_rate;
 
-    /** Encoding quality, 0-9, with 0 is the highest.                       */
+    /** Encoding quality, 0-9, with 0 is the highest quality. For VBR, the 
+     *  quality setting will only take effect when bit_rate setting is zero.
+     */
     unsigned    quality;