Changeset 748

Timestamp:

Oct 3, 2006 5:13:22 PM (18 years ago)

Author:

bennylp

Message:

Fixed bug in the hash table size calculation. The hash table creation API (pj_hash_create()) suggests that the size should be 2^{n-1, and when the size is not 2}n-1, it will be rounded-up to the nearest 2^{n-1, except when the size is exactly 2}n, then it will be rounded-down to 2^n-1.

The bug caused the hash table size to be doubled when application gives 2^{n size (instead of rounding it down to 2}n-1).

Nothing dangerous happened because of the bug, it just caused hash table size to be doubled the requirement.

Location:

pjproject/trunk/pjlib

Files:

• include/pj/hash.h (modified) (1 diff)
• src/pj/hash.c (modified) (1 diff)

pjproject/trunk/pjlib/include/pj/hash.h

@@ -84 +84 @@
  *
  * @param pool  the pool from which the hash table will be allocated from.
- * @param size  the bucket size, which will be round-up to the nearest 2^n+1
+ * @param size  the bucket size, which will be round-up to the nearest 2^n-1
  *
  * @return the hash table.

pjproject/trunk/pjlib/src/pj/hash.c

@@ -116 +116 @@
     do {
         table_size <<= 1;    
-    } while (table_size <= size);
+    } while (table_size < size);
     table_size -= 1;