Changeset 738 for pjproject/trunk/pjmedia/src/pjmedia-codec/ilbc.c

Timestamp:

Sep 25, 2006 1:40:12 PM (18 years ago)

Author:

bennylp

Message:

Tests with other user agents revealed some bugs which
have been fixed below:

• some UAs sends "telephone-event/8000/1" instead of "telephone-event/8000", which caused SDP negotiation to fail. Fixed in sdp_neg.c.
• codec name was (incorrectly) compared case-sensitively, causing negotiation to fail. Fixed in sdp_neg.c.
• Also improved error reporting in SDP negotiation by introducing few more error codes.
• Added Warning header in Not Acceptable response sent by pjsip_inv_session when SDP negotiation fails.
• PJSUA-LIB will try to negotiate both SDPs before sending 100 response.
• Fixed bug in iLBC codec when setting the mode to 30.

Also:

• Echo cancellation by default is disabled now since it doesn't seem to work. Further investigation needed.

File:

• pjproject/trunk/pjmedia/src/pjmedia-codec/ilbc.c (modified) (1 diff)

pjproject/trunk/pjmedia/src/pjmedia-codec/ilbc.c

@@ -396 +396 @@
     if (attr->setting.dec_fmtp_mode == 20)
         ilbc_codec->dec_frame_size = 38;
-    else if (attr->setting.dec_fmtp_mode == 20)
+    else if (attr->setting.dec_fmtp_mode == 30)
         ilbc_codec->dec_frame_size = 50;
     else {