Changeset 730 for pjproject

Timestamp:

Sep 19, 2006 9:29:19 PM (18 years ago)

Author:

bennylp

Message:

Fixed race condition bug when initializing SDP parser on multi-processor machine

File:

• pjproject/trunk/pjmedia/src/pjmedia/sdp.c (modified) (3 diffs)

pjproject/trunk/pjmedia/src/pjmedia/sdp.c

@@ -72 +72 @@
 static void init_sdp_parser(void)
 {
-    if (is_initialized == 0) {
-        is_initialized = 1;
-        if (is_initialized != 1) {
-            return;
-        }
-    }
-
+    if (is_initialized != 0)
+        return;
+
+    pj_enter_critical_section();
+
+    if (is_initialized != 0) {
+        pj_leave_critical_section();
+        return;
+    }
+    
     pj_cis_buf_init(&cis_buf);
 
@@ -88 +91 @@
     pj_cis_init(&cis_buf, &cs_digit);
     pj_cis_add_num(&cs_digit);
+
+    is_initialized = 1;
+    pj_leave_critical_section();
 }
 
@@ -1115 +1121 @@
         session = NULL;
 
+        pj_assert(ctx.last_error == PJ_SUCCESS);
     }
     PJ_END;