Changeset 713

Timestamp:

Sep 13, 2006 10:48:37 PM (18 years ago)

Author:

bennylp

Message:

SIP methods are now compared case-sensitively (previously it was case-insensitive) because the standard says so. There's no ill effect of the old behavior, but it's still important that we do things according to what the standard says.

Also a little change in string implementation (use memcmp() instead of strncmp()), an increase the version number from 0.5.7.6 to 0.5.7.7.

Location:

pjproject/trunk

Files:

• pjlib/include/pj/string_i.h (modified) (3 diffs)
• pjlib/src/pj/config.c (modified) (1 diff)
• pjsip/src/pjsip/sip_msg.c (modified) (1 diff)

pjproject/trunk/pjlib/include/pj/string_i.h

@@ -142 +142 @@
         return diff > 0 ? 1 : -1;
     } else if (str1->ptr && str1->slen) {
-        return pj_ansi_strncmp(str1->ptr, str2->ptr, str1->slen);
+        return memcmp(str1->ptr, str2->ptr, str1->slen);
     } else {
         return 0;
@@ -152 +152 @@
 {
     if (str1->ptr && str2->ptr)
-        return pj_ansi_strncmp(str1->ptr, str2->ptr, len);
+        return memcmp(str1->ptr, str2->ptr, len);
     else if (str2->ptr)
         return str2->slen==0 ? 0 : -1;
@@ -167 +167 @@
         return 0;
     else if (str1->ptr && str2)
-        return pj_ansi_strncmp(str1->ptr, str2, len);
+        return memcmp(str1->ptr, str2, len);
     else if (str1->ptr)
         return str1->slen==0 ? 0 : 1;

pjproject/trunk/pjlib/src/pj/config.c

@@ -22 +22 @@
 
 static const char *id = "config.c";
-const char *PJ_VERSION = "0.5.7.6";
+const char *PJ_VERSION = "0.5.7.7";
 
 PJ_DEF(void) pj_dump_config(void)

pjproject/trunk/pjsip/src/pjsip/sip_msg.c

@@ -227 +227 @@
         if (m1->id != PJSIP_OTHER_METHOD)
             return 0;
-        return pj_stricmp(&m1->name, &m2->name);
+        /* Method comparison is case sensitive! */
+        return pj_strcmp(&m1->name, &m2->name);
     }