Changeset 6141

Timestamp:

Jan 29, 2020 3:48:51 AM (5 years ago)

Author:

nanang

Message:

Misc (#2210): Added early check whether account is registered before sending unregistration in pjsua_acc_modify() (thanks to Peter Koletzki for the suggestion).

File:

• pjproject/trunk/pjsip/src/pjsua-lib/pjsua_acc.c (modified) (1 diff)

pjproject/trunk/pjsip/src/pjsua-lib/pjsua_acc.c

@@ -1411 +1411 @@
     /* Unregister first */
     if (unreg_first) {
-        status = pjsua_acc_set_registration(acc->index, PJ_FALSE);
-        if (status != PJ_SUCCESS) {
-            pjsua_perror(THIS_FILE, "Ignored failure in unregistering the "
-                         "old account setting in modifying account", status);
-            /* Not really sure if we should return error */
-            status = PJ_SUCCESS;
+        if (acc->regc) {
+            status = pjsua_acc_set_registration(acc->index, PJ_FALSE);
+            if (status != PJ_SUCCESS) {
+                pjsua_perror(THIS_FILE, "Ignored failure in unregistering the "
+                             "old account setting in modifying account",
+                             status);
+                /* Not really sure if we should return error */
+                status = PJ_SUCCESS;
+            }
         }
         if (acc->regc != NULL) {