Changeset 6133

Timestamp:

Jan 10, 2020 8:02:54 AM (5 years ago)

Author:

nanang

Message:

Misc (re #2210): Fixed memory leak in OpenSSL initialization due to unfreed SSL_SESSION object. The leak should only be occurred once in library lifetime. Thanks to Kim Daeyoung for the report.

File:

• pjproject/trunk/pjlib/src/pj/ssl_sock_ossl.c (modified) (3 diffs)

pjproject/trunk/pjlib/src/pj/ssl_sock_ossl.c

@@ -491 +491 @@
         SSL *ssl;
         STACK_OF(SSL_CIPHER) *sk_cipher;
+        SSL_SESSION *ssl_sess;
         unsigned i, n;
         int nid;
@@ -538 +539 @@
         ssl_cipher_num = n;
 
-        SSL_set_session(ssl, SSL_SESSION_new());
+        ssl_sess = SSL_SESSION_new();
+        SSL_set_session(ssl, ssl_sess);
 
 #if !USING_LIBRESSL && !defined(OPENSSL_NO_EC) \
@@ -568 +570 @@
 
         SSL_free(ssl);
+        SSL_SESSION_free(ssl_sess);
         SSL_CTX_free(ctx);
     }