Changeset 6000 for pjproject/trunk/pjlib-util/src/pjlib-util/resolver.c

Timestamp:

May 23, 2019 1:42:27 PM (5 years ago)

Author:

riza

Message:

Close #2200: Ignore/discard DNS SRV response with truncated flag set.

File:

• pjproject/trunk/pjlib-util/src/pjlib-util/resolver.c (modified) (1 diff)

pjproject/trunk/pjlib-util/src/pjlib-util/resolver.c

@@ -1777 +1777 @@
     pj_grp_lock_acquire(resolver->grp_lock);
 
-    /* Save/update response cache. */
-    update_res_cache(resolver, &q->key, status, PJ_TRUE, dns_pkt);
-    
+    /* Truncated responses MUST NOT be saved (cached). */
+    if (PJ_DNS_GET_TC(dns_pkt->hdr.flags) == 0) {
+        /* Save/update response cache. */
+        update_res_cache(resolver, &q->key, status, PJ_TRUE, dns_pkt);
+    }
+
     /* Recycle query objects, starting with the child queries */
     if (!pj_list_empty(&q->child_head)) {