Changeset 5994 for pjproject/trunk/pjsip-apps/src/pjsua/pjsua_app.c

Timestamp:

May 15, 2019 9:41:52 AM (5 years ago)

Author:

nanang

Message:

Re #2179: Wipe out memory used for storing SSL keys in PJSIP TLS transport and pjsua app. Thanks Peter Koletzki for the feedback.

File:

• pjproject/trunk/pjsip-apps/src/pjsua/pjsua_app.c (modified) (3 diffs)

pjproject/trunk/pjsip-apps/src/pjsua/pjsua_app.c

@@ -1794 +1794 @@
         status = pjsua_set_null_snd_dev();
         if (status != PJ_SUCCESS)
-            return status;
+            goto on_error;
     }
 #endif
@@ -1811 +1811 @@
     call_opt.aud_cnt = app_config.aud_cnt;
     call_opt.vid_cnt = app_config.vid.vid_cnt;
+
+    /* Wipe out TLS key settings in transport configs */
+    pjsip_tls_setting_wipe_keys(&app_config.udp_cfg.tls_setting);
 
     pj_pool_release(tmp_pool);
@@ -1960 +1963 @@
         cli_telnet_port = app_config.cli_cfg.telnet_cfg.port;   
     }
+
+    /* Wipe out TLS key settings in transport configs */
+    pjsip_tls_setting_wipe_keys(&app_config.udp_cfg.tls_setting);
 
     /* Reset config */