Changeset 5929 for pjproject/trunk/pjlib/src/pj/ssl_sock_gtls.c

Timestamp:

Jan 9, 2019 9:15:11 AM (5 years ago)

Author:

riza

Message:

Close #2174: Fix out of bound error when enabling GnuTLS.

File:

• pjproject/trunk/pjlib/src/pj/ssl_sock_gtls.c (modified) (2 diffs)

pjproject/trunk/pjlib/src/pj/ssl_sock_gtls.c

@@ -494 +494 @@
         unsigned int i;
 
-        for (i = 0; ; i++) {
+        for (i = 0; i<PJ_ARRAY_SIZE(tls_ciphers); i++) {
             unsigned char id[2];
             const char *suite;
@@ -504 +504 @@
              * ciphers anyway, so by checking here we can exit the loop as soon
              * as either all ciphers have been added or the array is full */
-            if (suite && i < PJ_ARRAY_SIZE(tls_ciphers)) {
+            if (suite) {
                 tls_ciphers[i].id = (pj_ssl_cipher)
                     (pj_uint32_t) ((id[0] << 8) | id[1]);