Changeset 5864

Timestamp:

Aug 21, 2018 8:06:43 AM (6 years ago)

Author:

ming

Message:

Fixed #2139: Fix potentially incorrect buffer allocation for video port renderer

File:

• pjproject/trunk/pjmedia/src/pjmedia/vid_port.c (modified) (2 diffs)

pjproject/trunk/pjmedia/src/pjmedia/vid_port.c

@@ -649 +649 @@
         const pjmedia_video_format_info *vfi;
         pjmedia_video_apply_fmt_param vafp;
-
-        vfi = pjmedia_get_video_format_info(NULL, vparam.fmt.id);
+        const pjmedia_vid_dev_param *vparam_src;
+
+        vparam_src = (vp->dir & PJMEDIA_DIR_RENDER)? &prm->vidparam:
+                     &vparam;
+
+        vfi = pjmedia_get_video_format_info(NULL, vparam_src->fmt.id);
         if (!vfi) {
             status = PJ_ENOTFOUND;
@@ -657 +661 @@
 
         pj_bzero(&vafp, sizeof(vafp));
-        vafp.size = vparam.fmt.det.vid.size;
+        vafp.size = vparam_src->fmt.det.vid.size;
         status = vfi->apply_fmt(vfi, &vafp);
         if (status != PJ_SUCCESS)