Changeset 5689

Timestamp:

Nov 10, 2017 3:16:30 AM (7 years ago)

Author:

ming

Message:

Fixed #2060: Prevent releasing unacquired lock when creating SIP dialog

File:

• pjproject/trunk/pjsip/src/pjsip/sip_dialog.c (modified) (3 diffs)

pjproject/trunk/pjsip/src/pjsip/sip_dialog.c

@@ -330 +330 @@
     pj_ssize_t len;
     pjsip_dialog *dlg;
+    pj_bool_t lock_incremented = PJ_FALSE;
 
     /* Check arguments. */
@@ -512 +513 @@
      * destroyed prematurely (such as in case of transport error).
      */
-    if (inc_lock)
+    if (inc_lock) {
         pjsip_dlg_inc_lock(dlg);
+        lock_incremented = PJ_TRUE;
+    }
 
     /* Create UAS transaction for this request. */
@@ -557 +560 @@
     }
 
-    if (inc_lock) {
+    if (lock_incremented) {
         pjsip_dlg_dec_lock(dlg);
     } else {