Changeset 5647 for pjproject

Timestamp:

Sep 11, 2017 10:31:03 AM (7 years ago)

Author:

riza

Message:

Re #1994(misc): Fixed unguarded 'if' which might lead to double locking. Thanks to Alexander Traud for the info.

File:

• pjproject/trunk/pjlib-util/src/pjlib-util/cli_telnet.c (modified) (2 diffs)

pjproject/trunk/pjlib-util/src/pjlib-util/cli_telnet.c

@@ -1492 +1492 @@
         case ST_CR:
             sess->parse_state = ST_NORMAL;
-            if (*cdata == 0 || *cdata == '\n')
+            if (*cdata == 0 || *cdata == '\n') {                
                 pj_mutex_unlock(sess->smutex);
                 is_valid = handle_return(sess);
@@ -1498 +1498 @@
                     return PJ_FALSE;
                 pj_mutex_lock(sess->smutex);
-                break;
+            }
+            break;
         case ST_NORMAL:
             if (*cdata == IAC) {