Changeset 5608

Timestamp:

Jun 20, 2017 4:12:09 AM (7 years ago)

Author:

riza

Message:

Fix #2023: Crash on pjsip_dlg_create_uac() when specifying URI with valueless
header parameter.

File:

• pjproject/trunk/pjsip/src/pjsip/sip_dialog.c (modified) (1 diff)

pjproject/trunk/pjsip/src/pjsip/sip_dialog.c

@@ -170 +170 @@
         param = uri->header_param.next;
         while (param != &uri->header_param) {
-            pjsip_hdr *hdr;
-            int c;
-
-            c = param->value.ptr[param->value.slen];
-            param->value.ptr[param->value.slen] = '\0';
-
-            hdr = (pjsip_hdr*)
-                  pjsip_parse_hdr(dlg->pool, &param->name, param->value.ptr,
-                                  param->value.slen, NULL);
-
-            param->value.ptr[param->value.slen] = (char)c;
-
-            if (hdr == NULL) {
-                status = PJSIP_EINVALIDURI;
-                goto on_error;
+            if (param->value.ptr) {
+                pjsip_hdr *hdr;
+                int c;
+
+                c = param->value.ptr[param->value.slen];
+                param->value.ptr[param->value.slen] = '\0';
+
+                hdr = (pjsip_hdr*)
+                    pjsip_parse_hdr(dlg->pool, &param->name, param->value.ptr,
+                                    param->value.slen, NULL);
+
+                param->value.ptr[param->value.slen] = (char)c;
+
+                if (hdr == NULL) {
+                    status = PJSIP_EINVALIDURI;
+                    goto on_error;
+                }
+                pj_list_push_back(&dlg->inv_hdr, hdr);
             }
-            pj_list_push_back(&dlg->inv_hdr, hdr);
 
             param = param->next;