Changeset 5583

Timestamp:

Apr 19, 2017 4:07:23 AM (8 years ago)

Author:

nanang

Message:

Re #2009: Avoid premature destroy in TURN session by incrementing group lock ref before performing async DNS resolution.

File:

• pjproject/trunk/pjnath/src/pjnath/turn_session.c (modified) (4 diffs)

pjproject/trunk/pjnath/src/pjnath/turn_session.c

@@ -629 +629 @@
         }
 
+        /* Add reference before async DNS resolution */
+        pj_grp_lock_add_ref(sess->grp_lock);
+
         status = pj_dns_srv_resolve(domain, &res_name, default_port, 
                                     sess->pool, resolver, opt, sess, 
@@ -634 +637 @@
         if (status != PJ_SUCCESS) {
             set_state(sess, PJ_TURN_STATE_NULL);
+            pj_grp_lock_dec_ref(sess->grp_lock);
             goto on_return;
         }
@@ -1726 +1730 @@
         set_state(sess, PJ_TURN_STATE_DESTROYING);
         sess_shutdown(sess, status);
+        pj_grp_lock_dec_ref(sess->grp_lock);
         return;
     }
@@ -1779 +1784 @@
             on_session_fail(sess, PJ_STUN_ALLOCATE_METHOD, status, NULL);
     }
+
+    pj_grp_lock_dec_ref(sess->grp_lock);
 }