Changeset 556

Timestamp:

Jun 27, 2006 12:15:56 PM (18 years ago)

Author:

bennylp

Message:

Fixed bug in transaction: ACK message is not deleted

File:

• pjproject/trunk/pjsip/src/pjsip/sip_transaction.c (modified) (1 diff)

pjproject/trunk/pjsip/src/pjsip/sip_transaction.c

@@ -2373 +2373 @@
                 pjsip_tx_data_dec_ref(tsx->last_tx);
                 tsx->last_tx = ack_tdata;
+
+                /* This is a bug.
+                   tsx_send_msg() does NOT decrement tdata's reference counter,
+                   so if we add the reference counter here, tdata will have
+                   reference counter 2, causing it to leak.
                 pjsip_tx_data_add_ref(ack_tdata);
+                */
             }