Changeset 5477

Timestamp:

Nov 1, 2016 4:10:17 AM (6 years ago)

Author:

riza

Message:

Re #1974: Fix DNS write on freed memory.
Thanks to Richard Mudgett for the patch.

File:

• pjproject/trunk/pjlib-util/src/pjlib-util/resolver.c (modified) (1 diff)

pjproject/trunk/pjlib-util/src/pjlib-util/resolver.c

@@ -930 +930 @@
             status = PJ_SUCCESS;
 
-            goto on_return;
+            /*
+             * We cannot write to *p_query after calling cb because what
+             * p_query points to may have been freed by cb.
+             * Refer to ticket #1974.
+             */
+            pj_mutex_unlock(resolver->mutex);
+            return status;
         }