Changeset 5435 for pjproject/trunk/pjsip/include/pjsip-ua/sip_inv.h

Timestamp:

Aug 30, 2016 8:40:18 AM (8 years ago)

Author:

riza

Message:

Re #1959: Add reference counter to pjsip_inv_session to avoid race condition.

File:

• pjproject/trunk/pjsip/include/pjsip-ua/sip_inv.h (modified) (3 diffs)

pjproject/trunk/pjsip/include/pjsip-ua/sip_inv.h

@@ -384 +384 @@
  * that the flip-flop pool's lifetimes are synchronized to the
  * SDP offer-answer negotiation.
+ *
+ * The lifetime of this session is controlled by the reference counter in this
+ * structure, which is manipulated by calling #pjsip_inv_add_ref and
+ * #pjsip_inv_dec_ref. When the reference counter has reached zero, then
+ * this session will be destroyed.
  */
 struct pjsip_inv_session
@@ -413 +418 @@
     pj_bool_t            following_fork;            /**< Internal, following
                                                          forked media?      */
+    pj_atomic_t         *ref_cnt;                   /**< Reference counter. */
 };
 
@@ -629 +635 @@
                                           unsigned options,
                                           pjsip_inv_session **p_inv);
+
+
+/**
+ * Add reference counter to the INVITE session. The reference counter controls
+ * the life time of the session, ie. when the counter reaches zero, then it 
+ * will be destroyed.
+ *
+ * @param inv       The INVITE session.
+ * @return          PJ_SUCCESS if the INVITE session reference counter
+ *                  was increased.
+ */
+PJ_DECL(pj_status_t) pjsip_inv_add_ref( pjsip_inv_session *inv );
+
+/**
+ * Decrement reference counter of the INVITE session.
+ * When the session is no longer used, it will be destroyed and
+ * caller is informed with PJ_EGONE return status.
+ *
+ * @param inv       The INVITE session.
+ * @return          PJ_SUCCESS if the INVITE session reference counter
+ *                  was decreased. A status PJ_EGONE will be returned to 
+ *                  inform that session is destroyed.
+ */
+PJ_DECL(pj_status_t) pjsip_inv_dec_ref( pjsip_inv_session *inv );