Changeset 4918 for pjproject/trunk

Timestamp:

Sep 9, 2014 4:10:59 AM (10 years ago)

Author:

ming

Message:

Fixed #1784: Remove the usage of nested structs/unions in PJSUA2 (unsupported by SWIG C++)

Location:

pjproject/trunk/pjsip

Files:

• include/pjsua2/call.hpp (modified) (3 diffs)
• include/pjsua2/siptypes.hpp (modified) (3 diffs)
• src/pjsua2/call.cpp (modified) (1 diff)

pjproject/trunk/pjsip/include/pjsua2/call.hpp

@@ -102 +102 @@
     MathStat        lossPeriodUsec; /**< Loss period statistics             */
 
-    struct {
-        unsigned    burst;      /**< Burst/sequential packet lost detected  */
-        unsigned    random;     /**< Random packet lost detected.           */
-    } lossType;                 /**< Types of loss detected.                */
+                                /**< Types of loss detected.                */
+    unsigned        burst;      /**< Burst/sequential packet lost detected  */
+    unsigned        random;     /**< Random packet lost detected.           */
     
     MathStat        jitterUsec; /**< Jitter statistics                      */
@@ -238 +237 @@
 
 /**
+ * Media event data.
+ */
+typedef union MediaEventData {
+    /**
+     * Media format changed event data.
+     */
+    MediaFmtChangedEvent    fmtChanged;
+    
+    /**
+     * Pointer to storage to user event data, if it's outside
+     * this struct
+     */
+    GenericData         ptr;
+
+} MediaEventData;
+
+/**
  * This structure describes a media event. It corresponds to the
  * pjmedia_event structure.
@@ -252 +268 @@
      * will be specific to the event type being reported.
      */
-    union {
-        /**
-         * Media format changed event data.
-         */
-        MediaFmtChangedEvent    fmtChanged;
-        
-        /**
-         * Pointer to storage to user event data, if it's outside
-         * this struct
-         */
-        GenericData             ptr;
-    } data;
+    MediaEventData              data;
     
     /**

pjproject/trunk/pjsip/include/pjsua2/siptypes.hpp

@@ -525 +525 @@
 
 /**
+ * This structure describes transaction state event source.
+ */
+struct TsxStateEventSrc
+{
+    SipRxData       rdata;          /**< The incoming message.      */
+    SipTxData       tdata;          /**< The outgoing message.      */
+    TimerEntry      timer;          /**< The timer.                 */
+    pj_status_t     status;         /**< Transport error status.    */
+    GenericData     data;           /**< Generic data.              */
+};
+
+/**
  * This structure describes transaction state changed event.
  */
 struct TsxStateEvent
 {
-    struct
-    {
-        SipRxData       rdata;          /**< The incoming message.      */
-        SipTxData       tdata;          /**< The outgoing message.      */
-        TimerEntry      timer;          /**< The timer.                 */
-        pj_status_t     status;         /**< Transport error status.    */
-        GenericData     data;           /**< Generic data.              */
-    } src;                              /**< Event source.              */
+    TsxStateEventSrc    src;            /**< Event source.              */
     SipTransaction      tsx;            /**< The transaction.           */
     pjsip_tsx_state_e   prevState;      /**< Previous state.            */
@@ -585 +590 @@
 
 /**
+ * The event body.
+ */
+struct SipEventBody
+{
+    /**
+     * Timer event.
+     */
+    TimerEvent      timer;
+    
+    /**
+     * Transaction state has changed event.
+     */
+    TsxStateEvent   tsxState;
+    
+    /**
+     * Message transmission event.
+     */
+    TxMsgEvent      txMsg;
+    
+    /**
+     * Transmission error event.
+     */
+    TxErrorEvent    txError;
+    
+    /**
+     * Message arrival event.
+     */
+    RxMsgEvent      rxMsg;
+    
+    /**
+     * User event.
+     */
+    UserEvent       user;
+    
+};
+
+/**
  * This structure describe event descriptor to fully identify a SIP event. It
  * corresponds to the pjsip_event structure in PJSIP library.
@@ -598 +640 @@
      * The event body, which fields depends on the event type.
      */
-    struct
-    {
-        /**
-         * Timer event.
-         */
-        TimerEvent      timer;
-        
-        /**
-         * Transaction state has changed event.
-         */
-        TsxStateEvent   tsxState;
-        
-        /**
-         * Message transmission event.
-         */
-        TxMsgEvent      txMsg;
-        
-        /**
-         * Transmission error event.
-         */
-        TxErrorEvent    txError;
-        
-        /**
-         * Message arrival event.
-         */
-        RxMsgEvent      rxMsg;
-        
-        /**
-         * User event.
-         */
-        UserEvent       user;
-        
-    } body;
+    SipEventBody        body;
     
     /**

pjproject/trunk/pjsip/src/pjsua2/call.cpp

@@ -57 +57 @@
     this->dup             = prm.dup;
     this->lossPeriodUsec.fromPj(prm.loss_period);
-    this->lossType.burst  = prm.loss_type.burst;
-    this->lossType.random = prm.loss_type.random;
+    this->burst           = prm.loss_type.burst;
+    this->random          = prm.loss_type.random;
     this->jitterUsec.fromPj(prm.jitter);
 }