Changeset 4837

Timestamp:

May 7, 2014 5:30:29 AM (11 years ago)

Author:

nanang

Message:

Re #1762: Fix native preview not shown issue by starting capture session from main thread.

File:

• pjproject/trunk/pjmedia/src/pjmedia-videodev/ios_dev.m (modified) (9 diffs)

pjproject/trunk/pjmedia/src/pjmedia-videodev/ios_dev.m

@@ -97 +97 @@
     VOutDelegate                *vout_delegate;
     void                        *capture_buf;
+    AVCaptureVideoPreviewLayer  *prev_layer;
     
     void                *render_buf;
@@ -715 +716 @@
             ios_init_view(strm);
             
-            CALayer *view_layer = strm->render_view.layer;
-            CGRect r = strm->render_view.bounds;
-            
             /* Preview layer instantiation should be in main thread! */
             dispatch_async(dispatch_get_main_queue(), ^{
@@ -726 +724 @@
                 
                 /* Attach preview layer to a UIView */
-                prev_layer.videoGravity = AVLayerVideoGravityResizeAspectFill;
-                prev_layer.frame = r;
-                [view_layer addSublayer:prev_layer];
+                prev_layer.videoGravity = AVLayerVideoGravityResize;
+                prev_layer.frame = strm->render_view.bounds;
+                [strm->render_view.layer addSublayer:prev_layer];
+                strm->prev_layer = prev_layer;
                 PJ_LOG(4, (THIS_FILE, "Native preview initialized"));
             });
@@ -832 +831 @@
             dispatch_async(dispatch_get_main_queue(), ^{
                 strm->render_view.bounds = r;
+                if (strm->prev_layer)
+                    strm->prev_layer.frame = r;
             });
             return PJ_SUCCESS;
@@ -891 +892 @@
 
     if (stream->cap_session) {
-        [stream->cap_session startRunning];
+        if ([NSThread isMainThread]) {
+            [stream->cap_session startRunning];
+        } else {
+            dispatch_sync(dispatch_get_main_queue(), ^{
+                [stream->cap_session startRunning];
+            });
+        }
     
         if (![stream->cap_session isRunning])
@@ -906 +913 @@
 {
     struct ios_stream *stream = (struct ios_stream*)strm;
-    //NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
     
     if (stream->frame_size >= frame->size)
@@ -914 +920 @@
     
     /* Perform video display in a background thread */
-    dispatch_async(dispatch_get_main_queue(),
-                   ^{[stream->vout_delegate update_image];});
-
-    //[pool release];
+    dispatch_async(dispatch_get_main_queue(), ^{
+        [stream->vout_delegate update_image];
+    });
     
     return PJ_SUCCESS;
@@ -931 +936 @@
     PJ_LOG(4, (THIS_FILE, "Stopping iOS video stream"));
 
-    if (stream->cap_session && [stream->cap_session isRunning])
-        [stream->cap_session stopRunning];
+    if (stream->cap_session && [stream->cap_session isRunning]) {
+        if ([NSThread isMainThread]) {
+            [stream->cap_session stopRunning];
+        } else {
+            dispatch_sync(dispatch_get_main_queue(), ^{
+                [stream->cap_session stopRunning];
+            });
+        }
+    }
     
     return PJ_SUCCESS;
@@ -965 +977 @@
     }
 
+    if (stream->prev_layer) {
+        CALayer *prev_layer = stream->prev_layer;
+        dispatch_async(dispatch_get_main_queue(), ^{
+            [prev_layer removeFromSuperlayer];
+            [prev_layer release];
+        });
+        stream->prev_layer = nil;
+    }
+    
     if (stream->render_view) {
         UIView *view = stream->render_view;
-        dispatch_async(dispatch_get_main_queue(),
-          ^{
-              [view removeFromSuperview];
-              [view release];
-           });
-        stream->render_view = NULL;
+        dispatch_async(dispatch_get_main_queue(), ^{
+            [view removeFromSuperview];
+            [view release];
+        });
+        stream->render_view = nil;
     }
     
     if (stream->render_data_provider) {
         CGDataProviderRelease(stream->render_data_provider);
-        stream->render_data_provider = NULL;
+        stream->render_data_provider = nil;
     }