Changeset 4774

Timestamp:

Feb 28, 2014 10:14:24 AM (10 years ago)

Author:

bennylp

Message:

Fixed #1719: Bug in DNS SRV/RFC 3263 server selection

File:

• pjproject/trunk/pjlib-util/src/pjlib-util/srv_resolver.c (modified) (3 diffs)

pjproject/trunk/pjlib-util/src/pjlib-util/srv_resolver.c

@@ -255 +255 @@
 
     /* Second pass:
-     *  pick one host among hosts with the same priority, according
-     *  to its weight. The idea is when one server fails, client should
-     *  contact the next server with higher priority rather than contacting
-     *  server with the same priority as the failed one.
+     *  Order the entry in a list.
      *
      *  The algorithm for selecting server among servers with the same
@@ -299 +296 @@
 
             /* Remove all other entries (of the same priority) */
+            /* Don't need to do this.
+             * See https://trac.pjsip.org/repos/ticket/1719
             while (count > 1) {
                 pj_array_erase(query_job->srv, sizeof(struct srv_target), 
@@ -305 +304 @@
                 --query_job->srv_cnt;
             }
+            */
         }
     }