Changeset 4639 for pjproject/branches/projects/pjsua2/pjsip/src/pjsua-lib/pjsua_core.c

Timestamp:

Nov 1, 2013 7:11:48 AM (10 years ago)

Author:

bennylp

Message:

Re #1519: Major change in pjsua2.i and etc after actual test in Python:

• Major changes in SWIG interface file (pjsua2.i).
  • The "ignore" and "unignore" approach caused link error with vector (duplicate symbols because SWIG generates two identical vector functions in the wrapper) so it cannot be used (tried with many combinations and still doesn't work).
  • So scrap that, and now we use "importing" approach, where needed symbols must be listed in symbols.lst file, then use importsym.py to import the symbol declarations to symbols.i. Then include symbols.i in pjsua.i
  • Due to the way importsym.py work, some macros and naked constants need to be placed into a named enumeration, for example:
    • #define PJ_SUCCESS 0 ==> enum pj_constants_ { PJ_SUCCESS=0 }; [types.h]
    • enum { PJMEDIA_VID_DEFAULT_CAPTURE_DEV = -1 } ==> enum pjmedia_vid_dev_std_index { PJMEDIA_VID_DEFAULT_CAPTURE_DEV = -1 }; [videodev.h]
  • Makefile was changed so that symbols.i would be generated if symbols.lst has changed
• Added "make install" and "make uninstall" targets for swig. Only implemented on Python. This will install to user's lib dir so doesn't need sudo.
• Deleted approachX.hpp files
• Added libVersion() method to Endpoint along with Version struct.
• Fix pjsua2.i to make exception (or redirection?) works in Python
• Add polling and worker thread related API:
  • PJSUA-LIB: pjsua_register_worker_thread(), pjsua_stop_worker_threads()
  • Endpoint: libRegisterWorkerThread(), libStopWorkerThreads(), libHandleEvents();

File:

• pjproject/branches/projects/pjsua2/pjsip/src/pjsua-lib/pjsua_core.c (modified) (2 diffs)

pjproject/branches/projects/pjsua2/pjsip/src/pjsua-lib/pjsua_core.c

@@ -687 +687 @@
 }
 
+PJ_DEF(pj_status_t) pjsua_register_worker_thread(const char *name)
+{
+    pj_thread_desc desc;
+    pj_thread_t *thread;
+    pj_status_t status;
+
+    if (pjsua_var.thread_quit_flag)
+        return PJ_EGONE;
+
+    status = pj_thread_register(NULL, desc, &thread);
+    if (status != PJ_SUCCESS)
+        return status;
+
+    if (name)
+        PJ_LOG(4,(THIS_FILE, "Worker thread %s started", name));
+
+    worker_thread(NULL);
+
+    if (name)
+        PJ_LOG(4,(THIS_FILE, "Worker thread %s stopped", name));
+
+    return PJ_SUCCESS;
+}
+
+PJ_DEF(void) pjsua_stop_worker_threads(void)
+{
+    unsigned i;
+
+    pjsua_var.thread_quit_flag = 1;
+
+    /* Wait worker threads to quit: */
+    for (i=0; i<(int)pjsua_var.ua_cfg.thread_cnt; ++i) {
+        if (pjsua_var.thread[i]) {
+            pj_status_t status;
+            status = pj_thread_join(pjsua_var.thread[i]);
+            if (status != PJ_SUCCESS) {
+                PJ_PERROR(4,(THIS_FILE, status, "Error joining worker thread"));
+                pj_thread_sleep(1000);
+            }
+            pj_thread_destroy(pjsua_var.thread[i]);
+            pjsua_var.thread[i] = NULL;
+        }
+    }
+}
 
 /* Init random seed */
@@ -1466 +1510 @@
 
     /* Signal threads to quit: */
-    pjsua_var.thread_quit_flag = 1;
-
-    /* Wait worker threads to quit: */
-    for (i=0; i<(int)pjsua_var.ua_cfg.thread_cnt; ++i) {
-        if (pjsua_var.thread[i]) {
-            pj_status_t status;
-            status = pj_thread_join(pjsua_var.thread[i]);
-            if (status != PJ_SUCCESS) {
-                PJ_PERROR(4,(THIS_FILE, status, "Error joining worker thread"));
-                pj_thread_sleep(1000);
-            }
-            pj_thread_destroy(pjsua_var.thread[i]);
-            pjsua_var.thread[i] = NULL;
-        }
-    }
+    pjsua_stop_worker_threads();
     
     if (pjsua_var.endpt) {