Changeset 4616 for pjproject

Timestamp:

Oct 8, 2013 11:15:22 AM (11 years ago)

Author:

bennylp

Message:

Re #1703 General bug fixes: fixed mutex not released on some error condition

Location:

pjproject/trunk/pjmedia/src/pjmedia

Files:

• codec.c (modified) (1 diff)
• vid_codec.c (modified) (1 diff)

pjproject/trunk/pjmedia/src/pjmedia/codec.c

@@ -637 +637 @@
     /* Update codec param */
     p->param = pjmedia_codec_param_clone(pool, param);
-    if (!p->param)
+    if (!p->param) {
+        pj_mutex_unlock(mgr->mutex);
         return PJ_EINVAL;
+    }
 
     pj_mutex_unlock(mgr->mutex);

pjproject/trunk/pjmedia/src/pjmedia/vid_codec.c

@@ -723 +723 @@
     /* Update codec default param */
     p->param = pjmedia_vid_codec_param_clone(pool, param);
-    if (!p->param)
+    if (!p->param) {
+        pj_mutex_unlock(mgr->mutex);
         return PJ_EINVAL;
+    }
 
     codec_desc->def_param = p;