Changeset 4613 for pjproject/trunk/pjnath/src/pjnath/errno.c

Timestamp:

Oct 8, 2013 9:08:13 AM (11 years ago)

Author:

bennylp

Message:

Re #1703: fixing general bugs. First installment: correct handling of snprintf return value

File:

• pjproject/trunk/pjnath/src/pjnath/errno.c (modified) (2 diffs)

pjproject/trunk/pjnath/src/pjnath/errno.c

@@ -134 +134 @@
                                    "Unknown pjnath error %d",
                                    statcode);
-    if (errstr.slen < 0) errstr.slen = 0;
-    else if (errstr.slen > (int)bufsize) errstr.slen = bufsize;
+    if (errstr.slen < 1 || errstr.slen >= (int)bufsize)
+        errstr.slen = bufsize-1;
 
     return errstr;
@@ -165 +165 @@
     }
 
-    if (errstr.slen < 0) errstr.slen = 0;
-    else if (errstr.slen > (int)bufsize) errstr.slen = bufsize;
+    if (errstr.slen < 1 || errstr.slen >= (int)bufsize)
+        errstr.slen = bufsize-1;
 
     return errstr;