Changeset 4579

Timestamp:

Aug 6, 2013 6:52:43 AM (11 years ago)

Author:

bennylp

Message:

Re #1669: fixed bug introduced by r4523 which caused pjsua_acc_modify() to always reregister regardless of whether there is change or not

File:

• pjproject/trunk/pjsip/src/pjsua-lib/pjsua_acc.c (modified) (3 diffs)

pjproject/trunk/pjsip/src/pjsua-lib/pjsua_acc.c

@@ -1049 +1049 @@
     {
         unsigned i;
+        pj_bool_t cred_changed = PJ_FALSE;
 
         /* Selective update credential info. */
@@ -1072 +1073 @@
             /* Not found, insert this */
             if (j == acc->cfg.cred_count) {
+                cred_changed = PJ_TRUE;
+
                 /* If account credential is full, discard the last one. */
                 if (acc->cfg.cred_count == PJ_ARRAY_SIZE(acc->cfg.cred_info)) {
@@ -1098 +1101 @@
         }
 
-        update_reg = PJ_TRUE;
-        unreg_first = PJ_TRUE;
+        if (cred_changed) {
+            update_reg = PJ_TRUE;
+            unreg_first = PJ_TRUE;
+        }
     }