Changeset 4495 for pjproject/trunk

Timestamp:

Apr 24, 2013 1:17:40 AM (12 years ago)

Author:

bennylp

Message:

Re #1656: fixes incorporated from latest email feedback

File:

• pjproject/trunk/pjmedia/src/pjmedia-audiodev/bb10_dev.c (modified) (4 diffs)

pjproject/trunk/pjmedia/src/pjmedia-audiodev/bb10_dev.c

@@ -443 +443 @@
     TRACE_((THIS_FILE, "pb_thread_func: size = %d ", size));
 
-    pthread_getschedparam(pthread_self(), &policy, &param);
-    param.sched_priority = 18;
-    pthread_setschedparam (pthread_self(), policy, &param);
+    if (pthread_getschedparam(pthread_self(), &policy, &param) == 0) {
+        param.sched_priority = 18;
+        pthread_setschedparam (pthread_self(), policy, &param);
+    }
 
     pj_bzero (buf, size);
@@ -538 +539 @@
     TRACE_((THIS_FILE, "ca_thread_func: size = %d ", size));
 
-    pthread_getschedparam(pthread_self(), &policy, &param);
-    param.sched_priority = 18;
-    pthread_setschedparam (pthread_self(), policy, &param);
+    if (pthread_getschedparam(pthread_self(), &policy, &param) == 0) {
+        param.sched_priority = 18;
+        pthread_setschedparam (pthread_self(), policy, &param);
+    }
 
     pj_bzero (buf, size);
@@ -721 +723 @@
 
     /* Required call from January 2013 gold OS release */
-    if ((ret = snd_pcm_plugin_set_disable(stream->pb_pcm,
-                                          PLUGIN_DISABLE_MMAP)) < 0)
-    {
-        TRACE_((THIS_FILE, "snd_pcm_plugin_set_disable ret = %d", ret));
-        return PJMEDIA_EAUD_SYSERR;
-    }
+    snd_pcm_plugin_set_disable(stream->pb_pcm, PLUGIN_DISABLE_MMAP);
 
     /* Required call from January 2013 gold OS release */
-    if ((ret = snd_pcm_plugin_set_enable(stream->pb_pcm,
-                                         PLUGIN_ROUTING)) < 0)
-    {
-        TRACE_((THIS_FILE, "snd_pcm_plugin_set_enable ret = %d", ret));
-        return PJMEDIA_EAUD_SYSERR;
-    }
+    /* Feedback on 24/04/2013: should not be used for "voice" port
+    snd_pcm_plugin_set_enable(stream->pb_pcm, PLUGIN_ROUTING);
+    */
 
     memset (&pi, 0, sizeof (pi));
@@ -828 +822 @@
     }
     /* Required call from January 2013 gold OS release */
-    if ((ret = snd_pcm_plugin_set_disable (stream->ca_pcm,
-                                           PLUGIN_DISABLE_MMAP)) < 0)
-    {
-        TRACE_((THIS_FILE, "snd_pcm_plugin_set_disable failed: %d",ret));
-        return PJMEDIA_EAUD_SYSERR;
-    }
+    snd_pcm_plugin_set_disable (stream->ca_pcm, PLUGIN_DISABLE_MMAP);
+
     /* Required call from January 2013 gold OS release */
-    if ((ret = snd_pcm_plugin_set_enable(stream->ca_pcm,
-                                         PLUGIN_ROUTING)) < 0)
-    {
-        TRACE_((THIS_FILE, "snd_pcm_plugin_set_enable failed: %d",ret));
-        return PJMEDIA_EAUD_SYSERR;
-    }
+    /* Feedback on 24/04/2013: should not be used for "voice" port
+    snd_pcm_plugin_set_enable(stream->ca_pcm, PLUGIN_ROUTING);
+    */
 
     /* sample reads the capabilities of the capture */