Changeset 4360 for pjproject/trunk/pjnath/include/pjnath/stun_transaction.h

Timestamp:

Feb 21, 2013 11:26:35 AM (11 years ago)

Author:

bennylp

Message:

Fixed #1617: major synchronization fixes in PJNATH with incorporation of group lock to avoid deadlock and crashes due to race conditions

File:

• pjproject/trunk/pjnath/include/pjnath/stun_transaction.h (modified) (5 diffs)

pjproject/trunk/pjnath/include/pjnath/stun_transaction.h

@@ -28 +28 @@
 #include <pjnath/stun_msg.h>
 #include <pjnath/stun_config.h>
+#include <pj/lock.h>
 
 
@@ -125 +126 @@
  *                      various settings for the transaction.
  * @param pool          Pool to be used to allocate memory from.
+ * @param grp_lock      Group lock to synchronize.
  * @param cb            Callback structure, to be used by the transaction
  *                      to send message and to notify the application about
@@ -134 +136 @@
 PJ_DECL(pj_status_t) pj_stun_client_tsx_create( pj_stun_config *cfg,
                                                 pj_pool_t *pool,
+                                                pj_grp_lock_t *grp_lock,
                                                 const pj_stun_tsx_cb *cb,
                                                 pj_stun_client_tsx **p_tsx);
@@ -160 +163 @@
 
 /**
- * Destroy a STUN client transaction immediately. This function can be 
- * called at any time to stop the transaction and destroy it.
+ * Stop the client transaction.
  *
  * @param tsx           The STUN transaction.
@@ -168 +170 @@
  *                      is NULL.
  */
-PJ_DECL(pj_status_t) pj_stun_client_tsx_destroy(pj_stun_client_tsx *tsx);
+PJ_DECL(pj_status_t) pj_stun_client_tsx_stop(pj_stun_client_tsx *tsx);