Changeset 4357 for pjproject/trunk

Timestamp:

Feb 19, 2013 8:05:59 PM (12 years ago)

Author:

bennylp

Message:

Fixed #1621: Handle the case when ICE session cannot create valid checklist

File:

• pjproject/trunk/pjnath/src/pjnath/ice_session.c (modified) (2 diffs)

pjproject/trunk/pjnath/src/pjnath/ice_session.c

@@ -967 +967 @@
     }
 
+    pj_assert(clist->count > 0);
     for (i=0; i<clist->count-1; ++i) {
         unsigned j, highest = i;
@@ -1691 +1692 @@
     }
 
+    /* This could happen if candidates have no matching address families */
+    if (clist->count == 0) {
+        LOG4((ice->obj_name,  "Error: no checklist can be created"));
+        pj_mutex_unlock(ice->mutex);
+        return PJ_ENOTFOUND;
+    }
+
     /* Sort checklist based on priority */
     sort_checklist(ice, clist);