Changeset 4095

Timestamp:

Apr 26, 2012 11:53:33 AM (12 years ago)

Author:

bennylp

Message:

Fixed #1495: UDP keep-alive is still running even after account is deleted. It cannot be updated with pjsua_acc_modify() either

File:

• pjproject/branches/1.x/pjsip/src/pjsua-lib/pjsua_acc.c (modified) (7 diffs)

pjproject/branches/1.x/pjsip/src/pjsua-lib/pjsua_acc.c

@@ -34 +34 @@
 
 static void schedule_reregistration(pjsua_acc *acc);
+static void keep_alive_timer_cb(pj_timer_heap_t *th, pj_timer_entry *te);
 
 /*
@@ -562 +563 @@
 PJ_DEF(pj_status_t) pjsua_acc_del(pjsua_acc_id acc_id)
 {
+    pjsua_acc *acc;
     unsigned i;
 
@@ -570 +572 @@
     PJSUA_LOCK();
 
+    acc = &pjsua_var.acc[acc_id];
+
+    /* Cancel keep-alive timer, if any */
+    if (acc->ka_timer.id) {
+        pjsip_endpt_cancel_timer(pjsua_var.endpt, &acc->ka_timer);
+        acc->ka_timer.id = PJ_FALSE;
+    }
+    if (acc->ka_transport) {
+        pjsip_transport_dec_ref(acc->ka_transport);
+        acc->ka_transport = NULL;
+    }
+
     /* Cancel any re-registration timer */
-    pjsua_cancel_timer(&pjsua_var.acc[acc_id].auto_rereg.timer);
+    pjsua_cancel_timer(&acc->auto_rereg.timer);
 
     /* Delete registration */
-    if (pjsua_var.acc[acc_id].regc != NULL) {
+    if (acc->regc != NULL) {
         pjsua_acc_set_registration(acc_id, PJ_FALSE);
-        if (pjsua_var.acc[acc_id].regc) {
-            pjsip_regc_destroy(pjsua_var.acc[acc_id].regc);
-        }
-        pjsua_var.acc[acc_id].regc = NULL;
+        if (acc->regc) {
+            pjsip_regc_destroy(acc->regc);
+        }
+        acc->regc = NULL;
     }
 
@@ -586 +600 @@
 
     /* Release account pool */
-    if (pjsua_var.acc[acc_id].pool) {
-        pj_pool_release(pjsua_var.acc[acc_id].pool);
-        pjsua_var.acc[acc_id].pool = NULL;
+    if (acc->pool) {
+        pj_pool_release(acc->pool);
+        acc->pool = NULL;
     }
 
     /* Invalidate */
-    pjsua_var.acc[acc_id].valid = PJ_FALSE;
-    pjsua_var.acc[acc_id].contact.slen = 0;
+    acc->valid = PJ_FALSE;
+    acc->contact.slen = 0;
 
     /* Remove from array */
@@ -838 +852 @@
     acc->cfg.timer_setting = cfg->timer_setting;
 
-    /* Transport and keep-alive */
+    /* Transport */
     if (acc->cfg.transport_id != cfg->transport_id) {
         acc->cfg.transport_id = cfg->transport_id;
         update_reg = PJ_TRUE;
     }
-    acc->cfg.ka_interval = cfg->ka_interval;
+
+    /* Update keep-alive */
+    if (acc->cfg.ka_interval != cfg->ka_interval ||
+        pj_strcmp(&acc->cfg.ka_data, &cfg->ka_data))
+    {
+        pjsip_transport *ka_transport = acc->ka_transport;
+
+        if (acc->ka_timer.id) {
+            pjsip_endpt_cancel_timer(pjsua_var.endpt, &acc->ka_timer);
+            acc->ka_timer.id = PJ_FALSE;
+        }
+        if (acc->ka_transport) {
+            pjsip_transport_dec_ref(acc->ka_transport);
+            acc->ka_transport = NULL;
+        }
+
+        acc->cfg.ka_interval = cfg->ka_interval;
+
+        if (cfg->ka_interval) {
+            if (ka_transport) {
+                /* Keep-alive has been running so we can just restart it */
+                pj_time_val delay;
+
+                pjsip_transport_add_ref(ka_transport);
+                acc->ka_transport = ka_transport;
+
+                acc->ka_timer.cb = &keep_alive_timer_cb;
+                acc->ka_timer.user_data = (void*)acc;
+
+                delay.sec = acc->cfg.ka_interval;
+                delay.msec = 0;
+                status = pjsua_schedule_timer(&acc->ka_timer, &delay);
+                if (status == PJ_SUCCESS) {
+                    acc->ka_timer.id = PJ_TRUE;
+                } else {
+                    pjsip_transport_dec_ref(ka_transport);
+                    acc->ka_transport = NULL;
+                    pjsua_perror(THIS_FILE, "Error starting keep-alive timer",
+                                 status);
+                }
+
+            } else {
+                /* Keep-alive has not been running, we need to (re)register
+                 * first.
+                 */
+                update_reg = PJ_TRUE;
+            }
+        }
+    }
+
     if (pj_strcmp(&acc->cfg.ka_data, &cfg->ka_data))
         pj_strdup(acc->pool, &acc->cfg.ka_data, &cfg->ka_data);
@@ -1527 +1590 @@
     }
 
+    /* Check just in case keep-alive has been disabled. This shouldn't happen
+     * though as when ka_interval is changed this timer should have been
+     * cancelled.
+     */
+    if (acc->cfg.ka_interval == 0)
+        goto on_return;
+
     /* Reschedule next timer */
     delay.sec = acc->cfg.ka_interval;
@@ -1537 +1607 @@
     }
 
+on_return:
     PJSUA_UNLOCK();
 }